kafka/server: add metrics and config for consumer lag reporting #24977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this commit contains only the metric infrastructure, i.e. the probe and the mechanism to dynamically enable/disable these metrics. A subsequent commit will implement the logic to populate the consumer lag metrics data.
IoannisRP
changed the title
CI test resultstest results on build#61359
|
| @@ -965,6 +967,7 @@ class group final : public ss::enable_lw_shared_from_this<group> { | |||
| chunked_hash_map<model::topic_partition, offset_metadata> | |||
| _pending_offset_commits; | |||
| enable_group_metrics _enable_group_metrics; | |||
| config::binding<bool> _enable_consumer_lag_metrics; | |||
There was a problem hiding this comment.
nit: you aren't using or assigning this in this commit so it should be moved to a different commit
Comment on lines
+681
to
+684
| # wait for some messages | ||
| wait_until( | ||
| lambda: ConsumerGroupTest.group_consumed_at_least( | ||
| consumers, 50 * len(consumers)), 30, 2) |
There was a problem hiding this comment.
nit: add an error message in wait_until
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: https://redpandadata.atlassian.net/browse/CORE-8914
Introduce "enable_consumer_group_lag_metrics" which controls whether the consumer lag metrics are active. This can be changed without needing a restart.
Introduce the metrics scaffolding needed to have metrics that can be enabled/disabled at runtime.
redpanda_kafka_consumer_group_lag_maxgroup,shardredpanda_kafka_consumer_group_lag_sumgroup,shardBackports Required
Release Notes