[v24.3.x] [UX-33] rpk: migrate login + profile creation flow to the Public API. #24995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done in the oauth.loadFlow of the normal login steps. Also renamed the publicapi.ControlPlaneClientSet to CloudClientSet since the clients can come from different services and not only the "controlplane" service. (cherry picked from commit 219adb2)
This is an ongoing migration to the new Cloud API. There is no difference for the end user. (cherry picked from commit ecfbbc8)
Instead of setting the inTest boolean on the test and having testing code in the implementation. (cherry picked from commit b142aa2)
r-vasquez
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #24877