CORE-8964 Add protobuf support to existing ducktape suite for schema evolution. #24998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks whether two structs are precisely equivalent[1] using a simultaneous depth-first traversal. The use case is for performing schema lookups on cached table metadata by type rather than by ID. [1] - Exclusive of IDs but inclusive of order. Signed-off-by: Oren Leiman <[email protected]>
Search for a schema that matches the provided type. Signed-off-by: Oren Leiman <[email protected]>
For catalog_schema_manager, we can use this to perform a type-wise schema lookup on cached metadata, resulting in table_info bound to an arbitrary schema rather (possibly) other than the current table schema. Also update catalog_schema_manager::get_ids_from_table_meta to try a type-wise lookup before performing the usual compat check. This way we can short-circuit a schema update if the desired schema is already present in the table. Also pass source struct to check_schema_compat by value to avoid polluting cached table metadata with compat annotations. Signed-off-by: Oren Leiman <[email protected]>
Rather than current schema ID. By this point we should have ensured that the record schema exists in the table (either historically or currently). This change lets us look past the current schema to build a writer for historical data. Signed-off-by: Oren Leiman <[email protected]>
Signed-off-by: Oren Leiman <[email protected]>
Specifically move producer and table verification methods onto AvroSchema in preparation for extending to something more generic (to support both avro & protobuf schemas) Signed-off-by: Oren Leiman <[email protected]>
Basically what it says on the tin. Avoid changing the semantics of any test cases, just add the ability to produce protobuf records of the same structure as the current avro ones. Signed-off-by: Oren Leiman <[email protected]>
Signed-off-by: Oren Leiman <[email protected]>
oleiman
force-pushed
the
dlib/core-8964/proto-dt-tests
branch
from
def67d8 to
76ba6c1
Compare
CI test resultstest results on build#61476
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test semantics don't change. Builds on a PR that is still in flight; first interesting commit is 12fbeae
Backports Required
Release Notes