Remove OS restriction for use-warp mode #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’d appreciate this as well. Right now I’m forced to write Reflex programs through WSL, which is fine but a bit clunky; it would be nice if I had a way to develop on Windows as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #414, removing these restrictions allows reflex-dom to build on Windows.
Since there isn't any test suite for reflex-dom and the test suite for reflex-dom-core is currently incompatible with Windows, the best I could do for testing is try to use reflex-dom to make an example site I found, since the built-in example is broken (see #422).
The site appeared to work fine on Chrome, but was completely unresponsive on Firefox, though I'm unsure if this is a Windows issue or an issue for reflex-dom in general.
Either way I think the best solution is to remove this restriction and let any windows bugs bubble up as issues, rather than barring a user from compiling under windows entirely, since the latter will turn away potential Windows users and therefore potential contributors to windows compatibility.
Fixes #414