Fix clusters loss when file renaming replaces target.

Add missing exfat_cleanup_node() call after exfat_unlink().
relan · Dec 19, 2015 · 1bacc53 · 1bacc53
1 parent 5bf2c77
commit 1bacc53
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/libexfat/node.c b/libexfat/node.c
@@ -1129,6 +1129,16 @@ int exfat_rename(struct exfat* ef, const char* old_path, const char* new_path)
 			}
 			exfat_put_node(ef, existing);
 			if (rc != 0)
+			{
+				/* free clusters even if something went wrong; overwise they
+				   will be just lost */
+				exfat_cleanup_node(ef, existing);
+				exfat_put_node(ef, dir);
+				exfat_put_node(ef, node);
+				return rc;
+			}
+			rc = exfat_cleanup_node(ef, existing);
+			if (rc != 0)
 			{
 				exfat_put_node(ef, dir);
 				exfat_put_node(ef, node);