Azure: Add support for ARM64 Images [SPSTRAT-467] #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAVGan
force-pushed
the
arm64
branch
3 times, most recently
from
b740fec to
e59eff6
Compare
|
@lslebodn this is my draft for supporting I will still add more tests to ensure it works as intended. The tests already cover:
Missing (TO DO):
|
JAVGan
commented
Nov 26, 2024
JAVGan
commented
Nov 27, 2024
JAVGan
force-pushed
the
arm64
branch
2 times, most recently
from
ca14541 to
23101fe
Compare
JAVGan
changed the title
This commit introduces the support for publishing ARM64 images on Azure
Marketplace through the product ingestion (Graph) API.
Since `arm64` images just uses `Gen2` it only preserves the logic of
multiple generations for `x64` and introduces a new SKU naming pattern
of: "{planID}-{arch}" for `arm64`.
With this change, the `publish` method is able to process either `x64`
or `arm64` images, one per call, as the `metadata.architecture` must
indicate one or another when publishing.
This commit also implements several unit tests to ensure the new
funcionlity works as intended and doesn't break the existing one for
`x64`.
The PR #68 removed the loop iteration over all SKUs which were not required for detecting the default/alternate generations for `x64`, however such iteration is required to detect the `security_type`. This commit fixes it by creating a dedicated helper function `_get_security_type` for this purpose only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the support for publishing ARM64 images on Azure Marketplace through the product ingestion (Graph) API.
Since
arm64images just usesGen2it only preserves the logic of multiple generations forx64and introduces a new SKU naming pattern of: "{planID}-{arch}" forarm64.With this change, the
publishmethod is able to process eitherx64orarm64images, one per call, as themetadata.architecturemust indicate one or another when publishing.This commit PR implements several unit tests to ensure the new funcionlity works as intended and doesn't break the existing one for
x64.Refers to SPSTRAT-467