Azure: Add missing alias for dateOffset #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a missing alias for the `date_offset` property on `DeprecationSchedule`. Without this alias the class was unable to properly parse the value from JSON, which may cause the following error when senting the request to configure: ``` 'badRequest', 'message': "The deprecation schedule for image 'X.Y.|' of type 'ARCH' is already published and can not be changed in draft." ``` Refers to SPMM-18578
lslebodn
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Nice catch. BTW there were even warnings in the code
2024-12-19 14:33:52 +0000 [WARNING ][ThreadPoolExecutor-pubtools-marketplacesvm-push-combined_0] Ignoring unknown attribute dateOffset from DeprecationSchedule.
2024-12-19 14:33:52 +0000 [WARNING ][ThreadPoolExecutor-pubtools-marketplacesvm-push-combined_0] Ignoring unknown attribute dateOffset from DeprecationSchedule.
2024-12-19 14:33:52 +0000 [WARNING ][ThreadPoolExecutor-pubtools-marketplacesvm-push-combined_0] Ignoring unknown attribute dateOffset from DeprecationSchedule.
2024-12-19 14:33:52 +0000 [WARNING ][ThreadPoolExecutor-pubtools-marketplacesvm-push-combined_0] Ignoring unknown attribute dateOffset from DeprecationSchedule.
2024-12-19 14:33:52 +0000 [WARNING ][ThreadPoolExecutor-pubtools-marketplacesvm-push-combined_0] Ignoring unknown attribute dateOffset from DeprecationSchedule.
2024-12-19 14:33:52 +0000 [WARNING ][ThreadPoolExecutor-pubtools-marketplacesvm-push-combined_0] Ignoring unknown attribute dateOffset from DeprecationSchedule.
But there is also another warning
2024-12-19 14:33:56 +0000 [WARNING ][ThreadPoolExecutor-pubtools-marketplacesvm-push-combined_0] Ignoring unknown attribute termsOfUseUrl from ProductProperty.
But very likely not very problematic :-)
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a missing alias for the
date_offsetproperty onDeprecationSchedule. Without this alias the class was unable to properly parse the value from JSON, which may cause the following error when senting the request to configure:Refers to SPMM-18578