Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Repository attrs [RHELDST-22483] #221

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

rbikar
Copy link
Member

@rbikar rbikar commented Apr 4, 2024

  • content_set was made properly optional via schema update
  • fix converters for eng_product_id which now properly handle None value when converting from or to pulp.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (994052e) to head (5e8ed84).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #221   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         3225      3225           
=========================================
  Hits          3225      3225           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* `content_set` was made properly optional via schema update
* fix converters for `eng_product_id` which now properly handles `None`
  value when converting from or to pulp.
@rbikar rbikar marked this pull request as ready for review April 4, 2024 12:02
@rbikar rbikar merged commit fa0f37d into release-engineering:master Apr 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants