Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tests for fake pulp support of RpmUnit files [RHELDST-21555] #222

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Implement tests for fake pulp support of RpmUnit files [RHELDST-21555] #222

merged 1 commit into from
Apr 23, 2024

Conversation

negillett
Copy link
Member

No description provided.

@negillett negillett force-pushed the 21555 branch 2 times, most recently from 69d78da to f24f113 Compare April 18, 2024 18:18
@negillett
Copy link
Member Author

@rbikar, @rohanpm @rajulkumar, if anyone has any advice here, it would be greatly appreciated.
To me, something seems broken if RpmDependency objects are coming into convert_field_to_pulp with subfield 'file' (which does happen without the final conditional). However, I also know what I'm attempting here is "wrong" but I'm not yet sure what is "correct".

@negillett negillett changed the title Update fake pulp to support RpmUnit files [RHELDST-21555] Implement tests for fake pulp support of RpmUnit files [RHELDST-21555] Apr 19, 2024
@negillett
Copy link
Member Author

cov passed but failed to upload to codecov.io

@negillett negillett marked this pull request as ready for review April 19, 2024 15:15
@negillett negillett requested a review from rohanpm April 19, 2024 15:15
rohanpm
rohanpm previously approved these changes Apr 22, 2024
View reviewed changes
@negillett negillett requested a review from rohanpm April 22, 2024 14:52
@negillett
Copy link
Member Author

Again, just failing upload to codecov

@rajulkumar
Copy link
Contributor

rajulkumar commented Apr 22, 2024 •
edited
Loading

Again, just failing upload to codecov

@negillett #223 should fix the upload to codecov

@negillett negillett merged commit 70a9b52 into release-engineering:master Apr 23, 2024
6 checks passed
@negillett negillett deleted the 21555 branch April 23, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanpm rohanpm rohanpm approved these changes

@rajulkumar rajulkumar rajulkumar approved these changes

@rbikar rbikar Awaiting requested review from rbikar rbikar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@negillett @rajulkumar @rohanpm