Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #139

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from c0ba2b7 to 908aa9c Compare January 6, 2025 23:30
@pre-commit-ci pre-commit-ci bot requested a review from a team as a code owner January 6, 2025 23:30
@zhanglu1122
Copy link
Contributor

Hi @hluk Any idea on the failed gating jobs? It seems to complain about the yaml format and I can see my ide is not happy with yaml format either, but I am not sure how to fix it.
Screenshot 2025-01-07 at 13 57 50

- version: 1
  name: "Example Rule"
  prerequisites:
    - condition: "major >= 10"
    - schedule_task: "GA for rhel {{ major }}.{{ minor }}"
    - target_date: "start_date - 7|days"
    - rule: "Dependent Rule 1"
    - rule: "Dependent Rule 2"
    - jira_issue_id: main
      template: "main.yaml.j2"
      subtasks:
        - id: add_beta_repos
          template: "add_beta_repos.yaml.j2"
        - id: notify_team
          template: "notify_team.yaml.j2"
    - jira_issue_id: secondary
      template: "secondary.yaml.j2"

- version: 1
  name: "Dependent Rule 1"
  prerequisites:
    - schedule_task: "TASK"
    - target_date: "start_date - 3|weeks"

- version: 1
  name: "Dependent Rule 2"
  prerequisites:
    - schedule_task: "TASK"
    - target_date: "start_date - 2|weeks"

@hluk
Copy link
Member

hluk commented Jan 7, 2025

Any idea on the failed gating jobs?

No idea. Validating the example rule file seems to print just 'format' in the CI. I cannot reproduce it locally.

This worked OK recently in CI and I don't see any related changes that would affect the bahavior.

@hluk
Copy link
Member

hluk commented Jan 7, 2025

Oh, I updated poetry locally (from 1.8.5 to 2.0.0) and now see the same problem!

poetry env remove --all
pip install --user -U poetry
poetry install --only=main
RETASC_CONFIG=examples/config.yaml poetry run retasc validate-rules examples/rules

@hluk
Copy link
Member

hluk commented Jan 7, 2025

Fix for the CI failure in #141.

updates:
- [github.com/asottile/pyupgrade: v3.19.0 → v3.19.1](asottile/pyupgrade@v3.19.0...v3.19.1)
- [github.com/astral-sh/ruff-pre-commit: v0.8.1 → v0.8.6](astral-sh/ruff-pre-commit@v0.8.1...v0.8.6)
- [github.com/renovatebot/pre-commit-hooks: 39.46.1 → 39.91.3](renovatebot/pre-commit-hooks@39.46.1...39.91.3)
@zhanglu1122 zhanglu1122 force-pushed the pre-commit-ci-update-config branch from 908aa9c to a0328d8 Compare January 7, 2025 07:15
@zhanglu1122 zhanglu1122 merged commit 82c5da8 into main Jan 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants