Detect lazy route discovery manifest version mismatches and trigger reloads #13061
+70
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 638e0fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
force-pushed
the
brophdawg11/tokyo-drift
branch
from
451e1f6 to
1ab0914
Compare
brophdawg11
commented
Feb 20, 2025
| if (discoveredPaths.has(path)) { | ||
| return; | ||
| } | ||
| await fetchAndApplyManifestPatches( | ||
| [path], | ||
| fetcherKey ? window.location.href : path, |
There was a problem hiding this comment.
Reload the current path on fetcher calls, or the next path on navigations
brophdawg11
force-pushed
the
brophdawg11/tokyo-drift
branch
from
72fbfb4 to
818bc00
Compare
jacob-ebey
reviewed
Feb 20, 2025
| // This will hard reload the destination path on navigations, or the | ||
| // current path on fetcher calls | ||
| if ( | ||
| sessionStorage.getItem(MANIFEST_VERSION_STORAGE_KEY) === |
jacob-ebey
approved these changes
Feb 20, 2025
|
@brophdawg11 This is great! We've had this issue on production and this is exactly what we've been waiting for 🥳 |
This was referenced Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds manifest version mismatch detection and forces a hard reload to get the user session onto the updated deployed version. Similar concept that we use when we hard reload on a route module asset 404.
Closes remix-run/remix#10455
Closes #12951