Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted vendor and code refactor #3

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Deleted vendor and code refactor #3

wants to merge 6 commits into from

Conversation

RohanSakhale
Copy link

@RohanSakhale RohanSakhale commented Apr 24, 2024 •
edited
Loading

  • Using the standards of composer for organising code and also seperation of tests from /src directory
  • Refactored code based on PSR-12 standard

@JonnyBurger
Copy link
Member

Hey Rohan!

Thanks a lot for your work on this.
This is great to see also for us on how to better structure a PHP package.

This repo does not contain the source code (see README of this repo), so I ported your PR over here: remotion-dev/remotion#3777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RohanSakhale @JonnyBurger