feat(captions): get hardcoded caption from render

remotion-dev · Sep 8, 2021 · 4c832be · 4c832be
1 parent 78194b7
commit 4c832be
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/packages/renderer/src/render.ts b/packages/renderer/src/render.ts
@@ -218,7 +218,16 @@ export const renderFrames = async ({
 		assetsInfo: {
 			assets,
 			bundleDir: webpackBundle,
-			captions: [],
+			// TODO: Figure out how to make this dynamic
+			captions: [
+				{
+					id: '123',
+					src: path.resolve(
+						__dirname,
+						'../../example/src/RemoteVideo/src/subs.srt'
+					),
+				},
+			],
 		},
 		frameCount,
 	};

diff --git a/packages/renderer/src/stitcher.ts b/packages/renderer/src/stitcher.ts
@@ -1,5 +1,4 @@
 import execa from 'execa';
-import path from 'path';
 import {
 	Codec,
 	ImageFormat,
@@ -126,10 +125,7 @@ export const stitchFramesToVideo = async (options: {
 		console.log('filters', filters);
 	}
 
-	const pathToSubtitle = path.resolve(
-		__dirname,
-		'../../example/src/RemoteVideo/src/subs.srt'
-	);
+	const {captions} = options.assetsInfo;
 
 	const {complexFilterFlag, cleanup} = await createFfmpegComplexFilter(filters);
 	const ffmpegArgs = [
@@ -141,7 +137,7 @@ export const stitchFramesToVideo = async (options: {
 			? ['-i', `element-%0${frameInfo.numberLength}d.${imageFormat}`]
 			: null,
 		...assetsToFfmpegInputs({
-			assets: assetPaths.concat([pathToSubtitle]),
+			assets: assetPaths.concat(captions.map((caption) => caption.src)),
 			isAudioOnly,
 			fps: options.fps,
 			frameCount: options.assetsInfo.assets.length,