Issue #389: Do not include a declaratively partitioned table with option --only-indexes
#398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion --only-indexes
|
Looks good, except tests for older versions are failing. |
Melkij
reviewed
May 16, 2024
Yeah. Looks like Postgres 10 and older versions don't support some features. Postgres 10 supports declarative partitioning, but it doesn't support indexes on partitioned tables ("parents"). I guess I'd need to rewrite the test to be able to test |
|
Merging the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the option
--only-indexesis used it doesn't make sense to repack indexes of a decoratively partitioned table since they don't store data. Therefore we can just ignore parent tables within the functionrepack_all_indexes().Issue: #389