Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sessionId and hardcoded provider #947

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Feb 10, 2025

Description

Implements hardcoded providers when sessionId query param is provided.

If the provider fails, it will fallback to normal routing logic.

As per the design doc.

Used by reown-com/yttrium#128

Fixes WK-555

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Feb 10, 2025
src/handlers/proxy.rs Outdated Show resolved Hide resolved
src/handlers/proxy.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@geekbrother geekbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@geekbrother geekbrother merged commit 3c80d85 into master Feb 10, 2025
15 checks passed
@geekbrother geekbrother deleted the feat/sessionid-hardcoded-provider branch February 10, 2025 22:17
Copy link

linear bot commented Feb 12, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants