Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: request & RPC ID analytics #949

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Feb 10, 2025

Description

Records the RPC ID and x-request-id header contents into the RPC analytics export.

This is useful to later link the x-request-id value with the chain abstraction data. Edit: this PR

Task list:

  • Remove rpc_id from analytics
  • Dump request
  • Dump response
  • Dump response status

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Feb 10, 2025
@@ -16,6 +17,9 @@ pub struct MessageInfo {
pub method: Arc<str>,
pub source: String,

pub request_id: String,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this Option for not falling back to unknown string here when it's not provided 🙏

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's better. Thought this was easier cus of the layered nesting but .ok() actually fixed that

Fixed in 036aa48

@chris13524 chris13524 changed the title feat: request & RPC ID analytics [do not merge yet] feat: request & RPC ID analytics Feb 12, 2025
@chris13524 chris13524 merged commit 06c6f44 into master Feb 12, 2025
15 checks passed
@chris13524 chris13524 deleted the feat/request-rpc-id-analytics branch February 12, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants