Add wallet_getAssets support + Chain Abstraction demo changes #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
17 Skipped Deployments
|
Deploying demo-ai-agents with
|
| Latest commit: |
bb1446f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://92cdb92d.demo-ai-agents.pages.dev |
| Branch Preview URL: | https://feat-wallet-getassets.demo-ai-agents.pages.dev |
| }; | ||
|
|
||
| // WalletConnect specific functions | ||
| const getWalletConnectAssets = async ( |
There was a problem hiding this comment.
Is this walletconnect specific or CAIP-25 specific?
Comment on lines
137
to
159
| // Embedded Wallet specific functions | ||
| const getEmbeddedWalletAssets = async ( | ||
| walletProvider: UniversalProvider, | ||
| request: WalletAssetRequest, | ||
| chainIdAsHex: Hex, | ||
| address: string | ||
| ): Promise<Record<Hex, Asset[]>[]> => { | ||
| const capabilities = await walletProvider.request({ | ||
| method: "wallet_getCapabilities", | ||
| params: [address] | ||
| }) as Capabilities; | ||
|
|
||
| if (!capabilities[chainIdAsHex]?.assetDiscovery?.supported) { | ||
| throw new Error("Wallet does not support wallet_getAssets"); | ||
| } | ||
|
|
||
| const response = await walletProvider.request({ | ||
| method: "wallet_getAssets", | ||
| params: [request], | ||
| }) as Record<Hex, Asset[]>; | ||
|
|
||
| return [response]; | ||
| }; |
There was a problem hiding this comment.
Why is this specific to our embedded wallet?
There was a problem hiding this comment.
need to rename the method, its not specific to Embedded wallet.
Comment on lines
177
to
180
| const assetsResponse = await (walletProviderType === "WALLET_CONNECT" | ||
| ? getWalletConnectAssets(walletProvider, request, chainIdAsHex, projectId!) | ||
| : getEmbeddedWalletAssets(walletProvider, request, chainIdAsHex, address) | ||
| ); |
There was a problem hiding this comment.
What if I connect with browser extension wallet for example?
| }; | ||
| } | ||
|
|
||
| async function aggregateERC20Balances( |
There was a problem hiding this comment.
why are we doing this dapp side?
There was a problem hiding this comment.
this is in the react-wallet
lukaisailovic
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wallet_getAssetsrpc on sample wallet servicewallet_getAssets