fix: Resolve provider creation error & add fallback for wallets without wallet_getAssets support #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KannuSingh
commented
Feb 17, 2025
•
KannuSingh
commented
- fix: cannot create provider error: The error cause due to incorrect lock file.
- add support for wallet not supporting wallet_getAssets with warning.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Skipped Deployments
|
Deploying demo-ai-agents with
|
| Latest commit: |
6d988f4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://027dbeac.demo-ai-agents.pages.dev |
| Branch Preview URL: | https://fix-deps-and-lock-file-confl.demo-ai-agents.pages.dev |
KannuSingh
changed the title
chris13524
reviewed
Feb 17, 2025
| @@ -74,7 +75,7 @@ function GiftDonutForm({ | |||
| variant="link" | |||
| size="sm" | |||
| onClick={() => setDonutCount(maxDonutPurchasable)} | |||
| disabled={count >= maxDonutPurchasable} | |||
| disabled={count === maxDonutPurchasable} | |||
There was a problem hiding this comment.
Should we just remove this attribute instead? This greys out text when it's exactly equal, but not sure why that would be desired.
Suggested change
| disabled={count === maxDonutPurchasable} |
chris13524
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.