Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash command api #501

Merged
merged 76 commits into from
Sep 14, 2023
Merged

Conversation

yofukashino
Copy link
Contributor

@yofukashino yofukashino commented Jun 28, 2023

adds support for slash commands. fixs the error in king fish's pr while adding the functionality to add custom sections and remove all commands you added with one function

edit: no more custom sections

@12944qwerty 12944qwerty self-assigned this Jun 28, 2023
@asportnoy asportnoy linked an issue Jul 9, 2023 that may be closed by this pull request
Copy link
Member

@colin273 colin273 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've decided not to support custom sections; all commands should go under a single section for Replugged.

@yofukashino
Copy link
Contributor Author

thats just gonna make things cluttered for users ngl

@colin273
Copy link
Member

I disagree. Multiple sections for Replugged will be cluttered in its own right, with too many underutilized sections.

@yofukashino
Copy link
Contributor Author

make it a required to get approved as plugin to either use default section or if using custom section then should have atlleast more than 10 commands ez

@12944qwerty
Copy link
Member

I don't know a single plugin that would use more than even 5 commands. And even if you could, it's definitely a lot better to use subcommands or choices instead.

@yofukashino
Copy link
Contributor Author

yofukashino commented Jul 22, 2023

but still having the option in api is nice. like you can discourage people from using it but removing it completely feels wrong. also idk how to use sub commands.

Edit: I might have known some plugins which can use more than 10 commands but they are kinda against tos of everything so better not state their name

@lexisother
Copy link
Member

What's so difficult to understand about "no"?

src/renderer/modules/injector.ts Outdated Show resolved Hide resolved
src/renderer/modules/injector.ts Outdated Show resolved Hide resolved
src/renderer/modules/injector.ts Outdated Show resolved Hide resolved
src/renderer/modules/injector.ts Outdated Show resolved Hide resolved
Copy link
Member

@FedeIlLeone FedeIlLeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Member

@colin273 colin273 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it

@asportnoy asportnoy merged commit ff7e806 into replugged-org:v4.7.0 Sep 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon development Relates to developing addons, eg APIs or scripts enhancement New feature or request semver: minor Requires a minor semver version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commands Coremod (switch to slash commands)
6 participants