Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context menu API fix #527

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Context menu API fix #527

merged 2 commits into from
Aug 3, 2023

Conversation

asportnoy
Copy link
Member

  • Fix context menu API for menus with only one item
  • Fix section not being added at the end for menus without a dev mode item

Closes #526

@asportnoy asportnoy added bug Something isn't working semver: patch Requires a patch semver version bump labels Aug 3, 2023
@yofukashino
Copy link
Contributor

I think I should merge this in my pr instead of separate one.

@lexisother lexisother merged commit 3242266 into main Aug 3, 2023
14 checks passed
@lexisother lexisother deleted the context-menu-api-fix branch August 3, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexisother lexisother lexisother approved these changes

Assignees
No one assigned
Labels
bug Something isn't working semver: patch Requires a patch semver version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Injector.utils#addMenuItem does not work with the ExpressionPicker
3 participants
@asportnoy @yofukashino @lexisother