ruby agent works with cucumber 3

reportportal · Jan 4, 2018 · 333beb4 · 333beb4
1 parent 35256fd
commit 333beb4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/report_portal/cucumber/formatter.rb b/lib/report_portal/cucumber/formatter.rb
@@ -44,6 +44,7 @@ def initialize(config)
             @queue.push([event_name, event, ReportPortal.now])
           end
         end
+        config.on_event :test_run_finished, &method(:done)
       end
 
       def puts(message)
@@ -56,8 +57,7 @@ def embed(*args)
         @queue.push([:embed, *args, ReportPortal.now])
       end
 
-      # @api private
-      def done
+      def done(_event)
         @queue.push([:done, ReportPortal.now])
         sleep 0.03 while !@queue.empty? || @queue.num_waiting == 0 # TODO: how to interrupt launch if the user aborted execution
         @thread.kill

diff --git a/lib/report_portal/cucumber/report.rb b/lib/report_portal/cucumber/report.rb
@@ -94,7 +94,7 @@ def test_step_started(event, desired_time = ReportPortal.now)
         test_step = event.test_step
         if step?(test_step) # `after_test_step` is also invoked for hooks
           step_source = test_step.source.last
-          message = "-- #{step_source.keyword}#{step_source.name} --"
+          message = "-- #{step_source.keyword}#{step_source.text} --"
           if step_source.multiline_arg.doc_string?
             message << %(\n"""\n#{step_source.multiline_arg.content}\n""")
           elsif step_source.multiline_arg.data_table?
@@ -114,7 +114,7 @@ def test_step_finished(event, desired_time = ReportPortal.now)
                              ex = result.exception
                              sprintf("%s: %s\n  %s", ex.class.name, ex.message, ex.backtrace.join("\n  "))
                            else
-                             sprintf("Undefined step: %s:\n%s", test_step.name, test_step.source.last.backtrace_line)
+                             sprintf("Undefined step: %s:\n%s", test_step.text, test_step.source.last.backtrace_line)
                            end
           ReportPortal.send_log(:error, exception_info, time_to_send(desired_time))
         end