Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.12 and 3.13. #45

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Support Python 3.12 and 3.13. #45

merged 5 commits into from
Jun 21, 2024

Conversation

mauritsvanrees
Copy link
Member

Skip testing with the crypt module when it does not exist, like on Python 3.13 and Windows. Fixes #44

Require legacy-cgi on Python 3.13 or higher so WebOb works.

Maybe then setup-python can find Python 3.13.
One job finishes correctly, but for the others I get this error:

```
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
```
@mauritsvanrees
Copy link
Member Author

@tseaver Could you review please? Thanks.

Copy link
Member

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great! I didn't know about the legacy-cgi option, and so had shied away from trying to get 3.13 compatibility for any of the repoze.* packages.

@tseaver
Copy link
Member

tseaver commented Jun 21, 2024

Note that this PR shouldn't close #44, as it doesn't really fix the issue: it just lets CI succeed on 3.13.

@tseaver tseaver merged commit d2912bf into repoze:master Jun 21, 2024
8 checks passed
@mauritsvanrees mauritsvanrees deleted the skip-crypt branch June 21, 2024 21:29
@mauritsvanrees
Copy link
Member Author

Changes look great! I didn't know about the legacy-cgi option, and so had shied away from trying to get 3.13 compatibility for any of the repoze.* packages.

I found legacy-cgi in zopefoundation/zope.testbrowser#108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'crypt'
2 participants