Fix calling bytes on serializer. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I saw this when using a checkout of `repoze.xmliter` and using `diazo` (from Plone). Added test that throws an error without this fix: ``` > self.assertTrue(b'<br />' in bytes(t)) E TypeError: __bytes__ returned non-bytes (type str) ```
The code has been changed to support Python 3 only.
tseaver
reviewed
Jan 30, 2024
|
After this is approved and merged, a release would be welcome. |
tseaver
approved these changes
Jan 31, 2024
|
Released 1.0b1: https://pypi.org/project/repoze.xmliter/1.0b1/ |
|
Thanks! With the previous release, in Plone I saw errors when trying to upgrade lxml to version 5. With the new release these should be gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got broken in commit eacd0f3, part of PR #13.