-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes allowing source mapping to work #62
base: master
Are you sure you want to change the base?
Conversation
- filename is a required option to compile() - Parens around a ternary, since ('name' + false ? '' : '.coffee') evaluates to '', not 'name.coffee'
LGTM |
Hey, just checking in - it would be great to get this accepted to making distributing code that uses this easier. |
I have a couple of questions: Firstly, from the demo code we have in this project, I couldn't see any difference between the compiled files using the old cs.js and your patched cs.js. Secondly, From #42
I think we should document this short-coming (maybe an update to the readme?) for future reference or another patch. |
This is super old, not even sure if it's an issue any more. It was a breaking issue, so I'm sure someone would have fixed it by now if so. |
It's weird why I didn't merge the PR back then. The issue hasn't been fixed. Partly because this project and coffeescript to a lesser extent, is nearly dead for some time now. Really sorry. 😐 I could merge it now, if you would like @dtilchin. Update - you'll just need to sign the CLA before I can merge it. |
|
Tested in Chrome 33 and Firefox 24. Without the first fix, the compile() fails because it tries to split() filename, which is undefined. See compile() in coffee-script.coffee in the CS source.