-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax lookup: Polyvar #318
Merged
ryyppy
merged 6 commits into
rescript-lang:master
from
kevanstannard:syntax-lookup-polyvar
May 24, 2021
Merged
Syntax lookup: Polyvar #318
ryyppy
merged 6 commits into
rescript-lang:master
from
kevanstannard:syntax-lookup-polyvar
May 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryyppy
reviewed
May 5, 2021
ryyppy
reviewed
May 5, 2021
Co-authored-by: Patrick Ecker <[email protected]>
Co-authored-by: Patrick Ecker <[email protected]>
@ryyppy thanks for the suggestions 👍, all resolved. |
Hi @ryyppy just bumping this one. Any more thoughts? |
ryyppy
reviewed
May 24, 2021
ryyppy
reviewed
May 24, 2021
ryyppy
reviewed
May 24, 2021
@kevanstannard thanks for bumping. Made some changes and merged it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion for #162
Is this the kind of content you were hoping for?
Also, I wasn't sure if we wanted to document some other polyvar syntaxes here as well, or keep as separate pages.
For example:
#value
[> #value]
[< #value]
Happy to be guided by you.
PR should be editable, so please feel free edit.