Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding REST_Axion_RayTracingNgamma.C macro #67

Merged
merged 5 commits into from
May 31, 2023
Merged

Conversation

jgalan
Copy link
Member

@jgalan jgalan commented May 26, 2023

jgalan Ok: 64

Adding a macro that extends the generated AnalysisTree dataset with new columns required for sensitivity analysis.

This macro could be in the framework since it makes use only of datasets. Although its scope is the calculation of probabilities and the normalisation of the simulation.

However, something similar will be required to normalise Geant4 MC simulations. @lobis

This PR requires the following PR to be merged: rest-for-physics/framework#427

@jgalan
Copy link
Member Author

jgalan commented May 30, 2023

Hi @juanangp the PR rest-for-physics/framework#427 has already been merged, which contains the new TRestDataSet::Define method required by the macro. So do you know why the pipelines are failing?

@juanangp
Copy link
Member

juanangp commented May 30, 2023

Hi @juanangp the PR rest-for-physics/framework#427 has already been merged, which contains the new TRestDataSet::Define method required by the macro. So do you know why the pipelines are failing?

No idea, I think I had a similar issue in the past, can you try to push something to this branch? Apparently you are not pointing to the appropiate master framework branch.

@jgalan
Copy link
Member Author

jgalan commented May 30, 2023

Ok, pushing again solved the problem

@jgalan jgalan marked this pull request as ready for review May 30, 2023 12:54
@jgalan jgalan requested review from jovoy and lobis May 30, 2023 12:54
@jgalan jgalan merged commit 2fe2766 into master May 31, 2023
@jgalan jgalan deleted the jgalan_ngamma_macro branch May 31, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants