Merge pull request #89 from rest-for-physics/jgalan-pipeline-fix

check_readout.sh fixing script issues
rest-for-physics · Jun 5, 2023 · a0d1e94 · a0d1e94
2 parents f298d8a + daaf5d7
commit a0d1e94
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/.github/workflows/validation.yml b/.github/workflows/validation.yml
@@ -104,7 +104,8 @@ jobs:
           cd ${{ env.DETECTOR_LIB_PATH }}/pipeline/readout
           restManager --c generateReadout.rml --o readout.root
           restRoot -b -q PrintReadout.C'("readout.root")' > print.txt
-          source check_readout.sh
+          diff print.txt validation.txt > output.txt
+          python3 checkLines.py
       # We need to introduce basic validation here
       #    - diff validation.txt print.txt
       # - name: Basic Readout

diff --git a/pipeline/readout/checkLines.py b/pipeline/readout/checkLines.py
@@ -0,0 +1,9 @@
+with open(r"output.txt", "r") as fp:
+    x = len(fp.readlines())
+
+    if x > 12:
+        print("Number of lines above 12!")
+        return 1
+    else:
+        print("Number of linesOK!")
+        return 0
diff --git a/pipeline/readout/check_readout.sh b/pipeline/readout/check_readout.sh