Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
 into alphaAna
  • Loading branch information
juanangp committed Apr 21, 2022
2 parents 157daa7 + 8f6c3d0 commit f0c7ef7
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 6 deletions.
19 changes: 13 additions & 6 deletions .github/pr-badge.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
- label: "PR Size"
message: "Large"
color: "red"
when: "$additions > 50"
- label: "PR submitted by:"
message: "$payload.pull_request.user.login"
color: "blue"
- label: "Size"
message: "$additions"
- label: "PR Size"
message: "Large: $additions"
color: "red"
when: "$additions > 250"
- label: "PR Size"
message: "Medium: $additions"
color: "orange"
when: "$additions > 99 && $additions < 251"
- label: "PR Size"
message: "Ok: $additions"
color: "green"
when: "$additions < 100"
- imageUrl: "https://gitlab.cern.ch/rest-for-physics/detectorlib/badges/$branchName/pipeline.svg"
url: "https://gitlab.cern.ch/rest-for-physics/detectorlib/-/commits/$branchName"
- imageUrl: "https://gitlab.cern.ch/rest-for-physics/framework/badges/$branchName/pipeline.svg"
url: "https://gitlab.cern.ch/rest-for-physics/framework/-/commits/$branchName"
26 changes: 26 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
Please, REMOVE this text! This is just a template to serve as a reminder.

Please, give as much detail as possible at your PR and create the simplest possible PR to facilitate reviewing.

If your PR fixes a given issue, please specify the number followed by #

Fixes #

Give a detailed list of changes proposed in this pull-request. For example:
- Feature added ...
- Upgraded class TRestXYZ to ...
- Added pipeline validation ...
- Documented ...
- Example added at ...
- Script ...


Once your PR is approved remember to **increase this library version** version following [these instructions](https://rest-for-physics.github.io/rest-advanced/new-release.html#generating-a-new-rest-library-version-release). Remember to have a look to our general [contribution guide](https://github.com/rest-for-physics/detectorlib/blob/master/CONTRIBUTING.md).

Reminder: Please, new features and upgrades should be sufficiently documented and a corresponding validation test at the pipeline should be implemented.

Reminder: Adding this to your PR description will notify members at the library_dev team: @rest-for-physics/detectorlib

Reminder: When writing your PR description remember to leave any necessary instructions to test the new implementation.

Reminder: to set-up the PR in the draft state when there is still work in progress, and make it ready once all pipelines have suceeded.

0 comments on commit f0c7ef7

Please sign in to comment.