Updating TRestRun metadata members #193
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A MAJOR update adding a NEW metadata member (fRunDuration) inside TRestRun and REMOVING an unused data member (fRunClassName),
I reviewed also the documentation of the data members
@rest-for-physics/core_dev
Additional remarks:
The reason behind adding a dedicated metadata member
fRunDuration
is because I expect this data member will store the effective time of a given number of runs. The idea is to implement aTRestDataSet
and exporting the data to a standard TTree or RDataFrame together with a TRestRun object (and other combined metadata objects). Therefore, the new TRestRun object should accumulate the total effective time (because there might be gaps).This is related to issue #13