Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpreal.h has been removed #407

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

mpreal.h has been removed #407

wants to merge 25 commits into from

Conversation

raulena333
Copy link
Contributor

@raulena333 raulena333 commented May 3, 2023

raulena333 Ok: 20

mpreal.h has been removed because it caused conflicts with some versions of MPFR libraries.

This compatibility issue seemed to be originated by the mpreal.h header present in the framework.

The mpreal.h is included inside the linux package libmpfrc++-dev

@raulena333 raulena333 requested review from jgalan and a team May 3, 2023 11:59
@jgalan
Copy link
Member

jgalan commented May 3, 2023

Hi @lobis, it would be better to include the library libmpfrc++-dev inside the docker. Because it creates problems when the mpfr-dev library does not match the same version as the hard coded header inside the framework.

It would be an issue to add that package to the docker?

@lobis
Copy link
Member

lobis commented May 3, 2023

Hi @lobis, it would be better to include the library libmpfrc++-dev inside the docker. Because it creates problems when the mpfr-dev library does not match the same version as the hard coded header inside the framework.

It would be an issue to add that package to the docker?

It should not be a problem (I assume it's installed as apt-get install libmpfrc++-dev in Ubuntu).

However its been a while since I modify the docker image and perhaps something can break due to some other circumstances, so I wouldn't update the "main" tag (the one we use for CI) of the Docker image without testing.

In fact we should transition from using the docker images I published in my profile to using an official rest-for-physics image as stated in #365. When I started working on it there were some problems I can't recall very well now and it got stuck, I can take a look this week and add this dependency, then update the CI image for all repositories.

I think from now on we should use https://github.com/rest-for-physics/rest-docker/issues to create requests / issues related to dependencies on the Docker image (I am assuming the official image will be hosted in this repository, after I fix the problems).

@jgalan
Copy link
Member

jgalan commented May 8, 2023

It should not be a problem (I assume it's installed as apt-get install libmpfrc++-dev in Ubuntu).

Yes, it is installed this way.

It has been added in the recent docker update?

@lobis
Copy link
Member

lobis commented May 8, 2023

It should not be a problem (I assume it's installed as apt-get install libmpfrc++-dev in Ubuntu).

Yes, it is installed this way.

It has been added in the recent docker update?

Yes it has been added, now we need to merge all PRs to update the image:

#413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants