TRestDataSetOdds fix and some more #492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to solve a problem when computing log odds for columns of the dataset with int values. This problem happens because the lambda function
GetLogOdds
requires thedouble val
parameter, which causes the TTreeReader to read the corresponding column as it was a double, thus causing error when the branch is not double type. To solve this in a simple way, the RDataFrame columns (of the selected observables to compute the log odds) that are not double types are Redefine with a static_cast to double. This solves the issue with simple types such as int (which is a common case).Also some minor additions (see list below).
The changes are: