Adding IAXO sensitivity examples and updating sensitivity classes when necessary #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… contain Component in the name
…might be generated with average number opf counts
for more information, see https://pre-commit.ci
jgalan
commented
May 29, 2024
| @@ -231,6 +237,9 @@ void TRestComponentFormula::InitFromConfigFile() { | |||
|
|
|||
| if (!fFormulas.empty()) return; | |||
|
|
|||
| /// For some reason I need to do this manually. Dont understand why! | |||
| fFormulaUnits = GetParameter("formulaUnits"); | |||
There was a problem hiding this comment.
@nkx111 may be you know why I needed to use this? This line seemed to solve my problems with formulaUnits initialization from config file. However, it seems to be working properly (I don't need to implement that line) for all members inside TRestAxionHelioscopeSignal that also inherits from TRestComponent.
AlvaroEzq
approved these changes
May 30, 2024
mariajmz
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes I had to add in order to properly calculate the axion helioscope sensitivity in the axionlib PR.
Some new features:
TRestComponentmay initialize parameterization nodes using initial/final values and a step. Linear o logarithmic scales are allowed.TRestExperiment::GenerateMockDataSetmight receive a boolean, when it is true, the number of counts of the mock dataset will be generated with the exact average from background, instead of performing a Poissonian MC-distribution.fUseAveragemember toTRestExperimentListandTRestExperimentso that we can enable/disable this feature.This PR is related to PR rest-for-physics/axionlib#93