Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRestEventSelectionProcess upgrade #528

Merged
merged 3 commits into from
Jun 25, 2024
Merged

TRestEventSelectionProcess upgrade #528

merged 3 commits into from
Jun 25, 2024

Conversation

AlvaroEzq
Copy link
Contributor

@AlvaroEzq AlvaroEzq commented Jun 24, 2024

AlvaroEzq Ok: 18 Powered by Pull Request Badge

Adding new possibility of using the TRestEventSelectionProcess without an external fileWithIDs by evaluating the conditions on the TRestAnalysisTree of the processing file itself.

@AlvaroEzq AlvaroEzq requested a review from nkx111 as a code owner June 24, 2024 10:47
@AlvaroEzq AlvaroEzq requested a review from DavidDiezIb June 24, 2024 10:48
@DavidDiezIb
Copy link
Member

I guess this was to include the selection process in the processing chain, right? Before it was only possible from existing files, not in the middle of the processing chain, am I correct?

@AlvaroEzq
Copy link
Contributor Author

I guess this was to include the selection process in the processing chain, right? Before it was only possible from existing files, not in the middle of the processing chain, am I correct?

Yes!

@lobis
Copy link
Member

lobis commented Jun 25, 2024

@AlvaroEzq I approve the PR but made some minor changes which shouldn't modify the behaviour:

  • std::string are already initialized as "", no need to explicitly do it.
  • Don't use new / delete if it can be avoided, in this case you can just create a regular (stack allocated) TRestRun which will be deleted when existing the scope.
  • Whenever you can try to use {} for all if statements and such, in my experience not using them for single-line expressions usually leads to mistakes down the road.

@lobis lobis self-requested a review June 25, 2024 07:31
@AlvaroEzq AlvaroEzq merged commit 2ffc29d into master Jun 25, 2024
64 checks passed
@AlvaroEzq AlvaroEzq deleted the aezquerro_eventSel branch June 25, 2024 09:14
lobis added a commit that referenced this pull request Sep 24, 2024
* 'master' of github.com:rest-for-physics/framework:
  TRestEventSelectionProcess upgrade (#528)
  Bump actions/checkout from 3 to 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants