Fix bugs in test regeneration #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `t/bin/create_test_entry.pl --regenerate --auto`, there was no processing of the `options` in the test file. This was due to my horrible choice to use package variables as configuration options. There's no easy way to "reset" them, so I punted on fixing it. This new version of the script forks a child and then munges the variables in the child. This automagically "resets" the global state. Use the new code to regenerate the `t/data` YAML. This just sorted keys, everything works as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
t/bin/create_test_entry.pl --regenerate --auto, there was no processing of theoptionsin the test file. This was due to my horrible choice to use package variables as configuration options. There's no easy way to "reset" them, so I punted on fixing it.This new version of the script forks a child and then munges the variables in the child. This automagically "resets" the global state.
Use the new code to regenerate the
t/dataYAML. This just sorted keys, everything works as intended.