bug in longFormat when rownames are numbers

rformassspectrometry · Jul 4, 2024 · 50612e6 · 50612e6
1 parent f857e08
commit 50612e6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -2,7 +2,9 @@
 
 ## QFeatures 1.15.2
 
-- New API unit test (see issue
+- Fix bug in `QFeatures::longFormat()` when rownames are numerical
+  (reported upstream https://github.com/waldronlab/MultiAssayExperiment/issues/331).
+- Starting New API unit test (see issue
   [#214](https://github.com/rformassspectrometry/QFeatures/issues/214).
 
 ## QFeatures 1.15.1

diff --git a/R/QFeatures-class.R b/R/QFeatures-class.R
@@ -822,7 +822,7 @@ longFormat <- function(object,
         rds <- do.call(rbind, rds)
         ## Merge the rowData to the long table
         cbind(longDataFrame,
-              rds[longDataFrame$rowname, , drop = FALSE])
+              rds[as.character(longDataFrame$rowname), , drop = FALSE])
     } else {
         ## If rowvars is null, return the MAE longFormat output
         MultiAssayExperiment::longFormat(object, colvars, index)