Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate option strategies #17

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

marc-at-brightnight
Copy link
Collaborator

No description provided.

marc added 2 commits March 24, 2024 19:16
- User should have the ability to create a strategy using defined and common option strategies
@marc-at-brightnight
Copy link
Collaborator Author

made some comments in examples/generate_strategies.ipynb. I realize now this is difficult to view in GitHub. Might be easier to view/comment on Jupyter notebook

]


def generate_strategies(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function name is misleading. And the most common options strategies are missing. Iron condor, butterfly, strangle, straddle, naked call, naked put are some that come to my mind.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not like much this module name. It's excessively generic and seems to imply that implementeing strategies requires using it. Perhaps something like common_strategies.py or a name that clearly indicates it's a helper module already implementing common strategies would be better.

@rgaveiga
Copy link
Owner

made some comments in examples/generate_strategies.ipynb. I realize now this is difficult to view in GitHub. Might be easier to view/comment on Jupyter notebook

I took a look at Jupyter. I found it weird that some strategies had a 100% probability of profit; I would need to verify the data that was provided as input. Although this can happen, it only occurs in very specific situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants