Fix notInterruptible flag for UnitCastingInfo and UnitChannelInfo in TBCC #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspervk
changed the title
|
Sorry the lib is for compatibility with retail version of the API, and you shouldn't use it on TBC to begin with |
|
oh wait, this is about LibTargetedCasts, i thought this was about casterino |
|
Thanks for reporting, i removed the whole bcc compatiblity thing and updated Aptechka too |
|
Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnitCastingInfoseems to be returning the same number of arguments as on retail, albeit still withnotInterruptible = nil. I have not testedUnitChannelInfo, but I assume they changed it in a similar way.