-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented API for set dbconnection #111
base: 3.x
Are you sure you want to change the base?
Conversation
Hi @unby, thanks for the contribution, it's much appreciated. What is the use case here? Using EFCore and Dapper at the same time? (not an arrangement that I've used before). I'd have thought it'd one or the other in most cases. Can you elaborate on the use case/s? Was it intentional that you've modified the EFCore 5 branch? Or should this be targeting EFCore 6? |
I want to use native API which can me get a lot of control
It does not have to be only Dapper I modified EFCore 5 branch because I tested the feature on my job project. I am ready to merge to EFCore 6 branch after code review |
Thanks, so it seems that provided Do you find you have to do further set up on the mocked There may be several approaches to support the use case. |
I want to emulate the database behind via DbConnection. I need to configure mock DbConnection |
@rgvlee, what do you think about the feature? |
I'm open to a change to the mock, but cautious about a change to the mock builder. The library provides functionality to extend the mock for supported relational operations. What we're saying here is that we're providing support for a mock db connection, but pushing any set up back on to the user rather than via the library. That in itself isn't a deal breaker, but how we deliver that needs to be considered. As this isn't a case that I have used personally, I'd like to try the use cases and assess what the MVP state of the db connection needs to be. From there I'll make a decision about whether we modify the mock itself, or the mock and the mock builder. |
I prepared full sample for continetue discussion |
Hi @rgvlee, can I prepare PR for 4.x brunch? |
I'm working my way through some bugfixes and enhancements, this is on my list of things to look into. Hold off on updating another branch just yet. |
Hi @rgvlee
Implemented a feature to set a specific DbConnection.
It allows testing dapper extensions with mock connection