minor fixes and update images #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erwangranger @guimou this PR solves some of the issues in #163 Can we double check that the Deploy of the Model in lab4 is using the Multi-Model serving platform? |
|
Currently, it does. We can look at using Single-Model serving instead in the example, but it feels less urgent than other changes. Multi-Model is fine for now IMO, but we can discuss. |
|
due the updates of the Multi-Model serving platform "only" applies to the RHOAI 2.8 version, should be wait until we moved the lab to this version and only fix the minor typos, not updating the images for RHOAI 2.8 in the lab? what do you think @erwangranger @guimou ? |
|
Merging as the Lab now runs on RHOAI 2.8 |
ritzshah
referenced
this pull request
in redhat-gpte-devopsautomation/rad-model-deployment
Aug 14, 2024
…minor-typos minor fixes and update images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor fixes and update images of RHOAI 2.8