Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

led brightness argument #101

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

llluis
Copy link
Contributor

@llluis llluis commented Feb 8, 2024

Second try
Request #98.

@blacknell
Copy link

this is great - much needed

@Pr0mises
Copy link

works great thank you

@Aohzan
Copy link

Aohzan commented Jun 27, 2024

hello @synesthesiam , can you check this PR 🙏

@TN-1
Copy link

TN-1 commented Jun 30, 2024

Working brilliantly, this is much needed in master. Can it be merged in please? Is there any work that is required?

parser.add_argument("--debug", action="store_true", help="Log DEBUG messages")
parser.add_argument("--led-brightness", type=int, default=31, help="LED brightness (integer from 1 to 31)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add choices=range(1, 32) to restrict the range?

@synesthesiam synesthesiam self-assigned this Jun 30, 2024
@synesthesiam
Copy link
Contributor

Small change requested and we're good to go 👍

@synesthesiam
Copy link
Contributor

Merging now. Will add changes afterwards.

@synesthesiam synesthesiam reopened this Jul 1, 2024
@synesthesiam synesthesiam merged commit 2f4276e into rhasspy:master Jul 1, 2024
2 checks passed
@huseman21
Copy link

I'm doing somthing wrong, This is how I am calling Wyoming-satellite but it errors out with the --led-brightness. any help?

[Service]
Type=simple
ExecStart=/home/me/wyoming-satellite/script/run --name 'my satellite' --led-brightness 5 --uri 'tcp://0.0.0.0:10700' --mic-command 'arecord -D plughw:CA>
WorkingDirectory=/home/huseman/wyoming-satellite
Restart=always
RestartSec=8

@Aohzan
Copy link

Aohzan commented Nov 15, 2024

It's an other service to run, my config (from 1 year ago)

[Unit]
Description=Respeaker LEDs

[Service]
Type=simple
ExecStart=/home/me/wyoming-satellite/examples/.venv/bin/python3 2mic_service.py --uri 'tcp://127.0.0.1:10500' --led-brightness 3
WorkingDirectory=/home/me/wyoming-satellite/examples
Restart=always
RestartSec=10

[Install]
WantedBy=default.target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants