Skip to content

Commit

Permalink
implement linting
Browse files Browse the repository at this point in the history
  • Loading branch information
rherwig committed Sep 28, 2018
1 parent 76be1f1 commit ef313ed
Show file tree
Hide file tree
Showing 9 changed files with 2,709 additions and 1,620 deletions.
29 changes: 29 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
{
"parser": "babel-eslint",
"parserOptions": {
"ecmaVersion": 2018
},
"plugins": [
"react"
],
"env": {
"browser": true,
"node": true
},
"rules": {
"indent": ["error", 4],
"global-require": "off",
"class-methods-use-this": "off",
"import/no-unresolved": "off",
"import/no-extraneous-dependencies": "off"
},
"settings": {
"react": {
"version": "16.5"
}
},
"extends": [
"eslint:recommended",
"plugin:react/recommended"
]
}
20 changes: 20 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,23 @@ server is started from `src/index.js`.
For more information on how the specific parts of the application work,
please refer to the documentation in the code.

## Testing
The general testing engine used by this project consists of jest and react-test-renderer.
You can run the tests by using the following command:
```
$ npm test
```

## Linting
To run eslint, execute the following command:
```
$ npm run lint
```

**Please note:** Linting is only available via this command and not integrated
via webpack. This is done on purpose, as eslint is somewhat biased on the preference
of the creator of the config.

## Building for Production
In order to build for production and run the finished project, execute
the following:
Expand All @@ -95,6 +112,9 @@ the template.
This change allows for much more flexibility, i.e. with [react-helmet](https://github.com/nfl/react-helmet)
and dynamically requiring content, such as styles.
* Introduces PostCSS to enable autoprefixer, since support of older browser (looking at you IE) is still important.
* Implement eslint and basic configuration.
* Implements basic test engine using jest.
* Improves production build by executing steps in parallel.

### 2.5.0
* Switched to babel 7
Expand Down
Loading

0 comments on commit ef313ed

Please sign in to comment.