-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: allow overriding module address #118
feature: allow overriding module address #118
Conversation
I think this approach looks good |
@kopy-kat requesting review |
nice - I think this looks good imo it would be useful to write a sanity test check to make sure when you override the constants that actually the overwritten constants are used (eg on a module installation function) - imo its overkill to do this for all functions but having a sanity check would be good |
Sounds good, I have added some unit tests in overrideConstants.test.ts file |
great, this looks good to me - could you just please fix the merge issues and then this is good to go |
Thanks |
No description provided.