tests: some stabilization changes #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
force-pushed
the
udevadm_settle_tests
branch
9 times, most recently
from
fab841f to
64ea325
Compare
KKoukiou
requested review from
martinpitt and
adamkankovsky
and removed request for
martinpitt
adamkankovsky
previously approved these changes
Feb 21, 2025
adamkankovsky
dismissed
their stale review
For some reason the tests started crashing in the part where s.udevadm_settle() was separated, but maybe it's just a flake
KKoukiou
force-pushed
the
udevadm_settle_tests
branch
from
64ea325 to
88b8ab3
Compare
Yes found the issue, thanks. |
KKoukiou
force-pushed
the
udevadm_settle_tests
branch
7 times, most recently
from
3c0db92 to
dd65e4f
Compare
KKoukiou
force-pushed
the
udevadm_settle_tests
branch
3 times, most recently
from
705dc8b to
4400c4d
Compare
KKoukiou
force-pushed
the
udevadm_settle_tests
branch
8 times, most recently
from
f05a8b9 to
4529323
Compare
This eliminates the needs to multiple disks re-scans
In this way we don't have to create new classes for test methods that need different disks.
KKoukiou
force-pushed
the
udevadm_settle_tests
branch
from
4529323 to
ceefeff
Compare
|
I know the single remaining failure problem, I will fix it tomorrow. |
KKoukiou
force-pushed
the
udevadm_settle_tests
branch
from
0e92db2 to
2fc320b
Compare
… and teardown * Ensure disks all disks are removed on both setup and teardown * Run udevadm settle after disk adding/removal operations * When adding disks, specify the target (vda, vdb). Often disks were added with /dev/vdb altough /dev/vda was expected
I suspect there is some cleanup missing for these.
There is some cleanup missing from this.
I believe there is some race condition with blivet not parsing the partitions propertly.
KKoukiou
force-pushed
the
udevadm_settle_tests
branch
from
2fc320b to
91f793a
Compare
adamkankovsky
approved these changes
Mar 3, 2025
rvykydal
approved these changes
Mar 3, 2025
|
TestStorageMountPointsRAID_E2E seems to have broken in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.