storage: cockpit-storage: select newly created mdarrays if the user created them #658
Conversation
KKoukiou
force-pushed
the
raid-testcase-fedora-beta
branch
3 times, most recently
from
75745e8 to
e03aa2b
Compare
…reated them Inn blivet we recognize two "types" of MD array: * The array is directly on top of disks: in this case we consider the array to be a disk (similar to a hardware RAID) and create the partition table on the array * The array is on top of partitions: from our pov this is a device and we allow only a single filesystem (or other format like lvmpv) on top of it and if it has partitions they are ignored For the first scenario, we need to re-set 'SelectedDisks' in backend, for the new mdarrays to be handled as such.
One test is RAID on top of disks, the other test is RAID on top of partitions.
KKoukiou
force-pushed
the
raid-testcase-fedora-beta
branch
from
e03aa2b to
2508bd5
Compare
| message: cockpit.format( | ||
| _( | ||
| "Invalid RAID configuration detected.\n" + | ||
| "If your RAID array is created directly on top of disks, a partition table must be created on the array.\n" + |
There was a problem hiding this comment.
@vojtechtrefny we discussed this last week, I think we should move this logic elsewere, (blivet and fedora documentation)
But for resolving fast the bug, can you please review this error message?
There was a problem hiding this comment.
Strictly speaking, the first part is not true -- we support disks with filesystem without partition table, it's just not something generally recommend (and doesn't make much sense during installation anyway). But I am not really sure what will Anaconda do with disks like that (I think default behaviour is to create a new partition table on all selected disks) so I guess it makes sense to mark it as unsupported.
|
@rvykydal added one more test with the corresponding code logic for detecting invalid raid configuration. |
| message: cockpit.format( | ||
| _( | ||
| "Invalid RAID configuration detected.\n" + | ||
| "If your RAID array is created directly on top of disks, a partition table must be created on the array.\n" + |
There was a problem hiding this comment.
Strictly speaking, the first part is not true -- we support disks with filesystem without partition table, it's just not something generally recommend (and doesn't make much sense during installation anyway). But I am not really sure what will Anaconda do with disks like that (I think default behaviour is to create a new partition table on all selected disks) so I guess it makes sense to mark it as unsupported.
Use rsync instead of cp to exclude unnecessary paths (/dev, /proc, /sys, etc.), ensuring a more reliable system transfer, as cp got stuck often.
KKoukiou
force-pushed
the
raid-testcase-fedora-beta
branch
2 times, most recently
from
26be4f5 to
2c06a27
Compare
Resolves: rhbz#2344434
KKoukiou
force-pushed
the
raid-testcase-fedora-beta
branch
from
2c06a27 to
8d70d7a
Compare
|
The remaining test failures are unrelated. |
No description provided.