Adding dbus interface for loading locale keyboards #6093

adamkankovsky · 2025-01-14T09:29:35Z

No description provided.

pep8speaks · 2025-01-14T11:24:42Z

Hello @adamkankovsky! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pyanaconda/modules/common/structures/keyboard_layout.py:

Line 49:32: E231 missing whitespace after ':'
Line 58:26: E231 missing whitespace after ':'

In the file pyanaconda/modules/localization/localization.py:

Line 57:1: E731 do not assign a lambda expression, use a def
Line 58:1: E731 do not assign a lambda expression, use a def

Comment last updated at 2025-01-23 13:22:16 UTC

pyanaconda/localization.py

jkonecny12 · 2025-01-14T17:21:26Z

Also we shouldn't forget about localization of the layouts
https://github.com/rhinstaller/anaconda/blob/main/pyanaconda%2Fui%2Fgui%2Fxkl_wrapper.py#L32-L33

We can resolve on the UI side or provide a separate API for that. Something like get_localized. Not sure what is better approach

jkonecny12

Thanks a lot for this improvement! I would like to know what do you think about the notes below before setting ACK.

pyanaconda/modules/localization/localization.py

pyanaconda/localization.py

pyanaconda/ui/gui/xkl_wrapper.py

jkonecny12

Looks good to me.

I just wonder how we are going to resolve the localization? Will that be DBus API or a UI code?

adamkankovsky · 2025-01-16T09:30:38Z

/kickstart-test --testtype smoke

adamkankovsky · 2025-02-11T12:18:31Z

/build-image --boot.iso

github-actions · 2025-02-11T12:19:37Z

Images built based on commit 6981c6e:

boot.iso: failure

Download the images from the bottom of the job status page.

adamkankovsky · 2025-02-11T14:07:45Z

/kickstart-test reboot-initial-setup-tui

KKoukiou · 2025-02-12T07:19:56Z

/kickstart-test reboot-initial-setup-tui

KKoukiou · 2025-02-12T07:20:56Z

/kickstart-test reboot-initial-setup-tui

KKoukiou · 2025-02-12T07:32:09Z

/build-image

github-actions · 2025-02-12T07:45:27Z

Images built based on commit a8885f0:

boot.iso: success

Download the images from the bottom of the job status page.

KKoukiou · 2025-02-12T08:10:59Z

/kickstart-test reboot-initial-setup-tui --kstest-pr 1366

KKoukiou · 2025-02-12T08:11:19Z

/kickstart-test --kstest-pr 1366 reboot-initial-setup-tui

adamkankovsky · 2025-02-12T08:56:14Z

/kickstart-test --kstest-pr 1366 reboot-initial-setup-tui

KKoukiou · 2025-02-12T11:56:46Z

/kickstart-test --kstest-pr 1366 reboot-initial-setup-tui

adamkankovsky · 2025-02-12T12:47:50Z

/kickstart-test reboot-initial-setup-tui

adamkankovsky · 2025-02-12T13:21:37Z

/kickstart-test --testtype smoke

Adding dbus interface for loading locale keyboards Remove duplicate function and migrate to localization one

adamkankovsky · 2025-02-12T13:23:09Z

/kickstart-test --testtype smoke

adamkankovsky temporarily deployed to gh-cockpituous January 14, 2025 09:29 — with GitHub Actions Inactive

github-actions bot added the f42 Fedora 42 label Jan 14, 2025

adamkankovsky force-pushed the localization-keyboard branch from 7d20779 to 7e0b385 Compare January 14, 2025 09:30

adamkankovsky temporarily deployed to gh-cockpituous January 14, 2025 09:30 — with GitHub Actions Inactive

adamkankovsky requested a review from KKoukiou January 14, 2025 09:32

adamkankovsky force-pushed the localization-keyboard branch from 7e0b385 to 879695c Compare January 14, 2025 11:24

adamkankovsky temporarily deployed to gh-cockpituous January 14, 2025 11:24 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from 879695c to 84b7321 Compare January 14, 2025 12:33

adamkankovsky temporarily deployed to gh-cockpituous January 14, 2025 12:33 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from 84b7321 to b14b523 Compare January 14, 2025 12:37

adamkankovsky temporarily deployed to gh-cockpituous January 14, 2025 12:37 — with GitHub Actions Inactive

adamkankovsky requested a review from jkonecny12 January 14, 2025 14:20

jkonecny12 requested changes Jan 14, 2025

View reviewed changes

pyanaconda/localization.py Outdated Show resolved Hide resolved

adamkankovsky force-pushed the localization-keyboard branch from b14b523 to 5847497 Compare January 15, 2025 12:49

adamkankovsky temporarily deployed to gh-cockpituous January 15, 2025 12:49 — with GitHub Actions Inactive

adamkankovsky requested a review from jkonecny12 January 15, 2025 13:19

jkonecny12 requested changes Jan 15, 2025

View reviewed changes

pyanaconda/modules/localization/localization.py Outdated Show resolved Hide resolved

pyanaconda/localization.py Outdated Show resolved Hide resolved

pyanaconda/ui/gui/xkl_wrapper.py Show resolved Hide resolved

adamkankovsky force-pushed the localization-keyboard branch from 5847497 to f722550 Compare January 15, 2025 14:06

adamkankovsky temporarily deployed to gh-cockpituous January 15, 2025 14:06 — with GitHub Actions Inactive

adamkankovsky requested a review from jkonecny12 January 15, 2025 14:07

adamkankovsky force-pushed the localization-keyboard branch from f722550 to d5bf365 Compare January 15, 2025 15:15

adamkankovsky temporarily deployed to gh-cockpituous January 15, 2025 15:16 — with GitHub Actions Inactive

jkonecny12 approved these changes Jan 15, 2025

View reviewed changes

adamkankovsky force-pushed the localization-keyboard branch from d5bf365 to efd8ae2 Compare January 16, 2025 13:30

adamkankovsky temporarily deployed to gh-cockpituous January 16, 2025 13:30 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from efd8ae2 to 1e474e6 Compare January 16, 2025 13:42

adamkankovsky temporarily deployed to gh-cockpituous January 16, 2025 13:42 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from 6981c6e to 9321cec Compare February 11, 2025 13:41

adamkankovsky temporarily deployed to gh-cockpituous February 11, 2025 13:41 — with GitHub Actions Inactive

KKoukiou force-pushed the localization-keyboard branch from 9321cec to 2156fe4 Compare February 12, 2025 07:19

KKoukiou temporarily deployed to gh-cockpituous February 12, 2025 07:19 — with GitHub Actions Inactive

KKoukiou force-pushed the localization-keyboard branch from 2156fe4 to a8885f0 Compare February 12, 2025 07:20

KKoukiou temporarily deployed to gh-cockpituous February 12, 2025 07:20 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from a8885f0 to 5d8bdc0 Compare February 12, 2025 11:13

adamkankovsky temporarily deployed to gh-cockpituous February 12, 2025 11:13 — with GitHub Actions Inactive

adamkankovsky force-pushed the localization-keyboard branch from 5d8bdc0 to 80a2b9d Compare February 12, 2025 11:32

adamkankovsky temporarily deployed to gh-cockpituous February 12, 2025 11:32 — with GitHub Actions Inactive

KKoukiou approved these changes Feb 12, 2025

View reviewed changes

adamkankovsky added 2 commits February 12, 2025 14:22

Add test for GetLocaleKeyboardLayouts

2625733

Creating a dbus interface to get local keyboard layouts

f4aee10

Adding dbus interface for loading locale keyboards Remove duplicate function and migrate to localization one

adamkankovsky force-pushed the localization-keyboard branch from 80a2b9d to f4aee10 Compare February 12, 2025 13:22

adamkankovsky temporarily deployed to gh-cockpituous February 12, 2025 13:23 — with GitHub Actions Inactive

jkonecny12 approved these changes Feb 12, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding dbus interface for loading locale keyboards #6093

Adding dbus interface for loading locale keyboards #6093

adamkankovsky commented Jan 14, 2025

pep8speaks commented Jan 14, 2025 •

edited

Loading

jkonecny12 commented Jan 14, 2025 •

edited

Loading

jkonecny12 left a comment

jkonecny12 left a comment

adamkankovsky commented Jan 16, 2025

adamkankovsky commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

adamkankovsky commented Feb 11, 2025

KKoukiou commented Feb 12, 2025

KKoukiou commented Feb 12, 2025

KKoukiou commented Feb 12, 2025

github-actions bot commented Feb 12, 2025

KKoukiou commented Feb 12, 2025

KKoukiou commented Feb 12, 2025

adamkankovsky commented Feb 12, 2025

KKoukiou commented Feb 12, 2025

adamkankovsky commented Feb 12, 2025

adamkankovsky commented Feb 12, 2025

adamkankovsky commented Feb 12, 2025

Adding dbus interface for loading locale keyboards #6093

Are you sure you want to change the base?

Adding dbus interface for loading locale keyboards #6093

Conversation

adamkankovsky commented Jan 14, 2025

pep8speaks commented Jan 14, 2025 • edited Loading

Comment last updated at 2025-01-23 13:22:16 UTC

jkonecny12 commented Jan 14, 2025 • edited Loading

jkonecny12 left a comment

Choose a reason for hiding this comment

jkonecny12 left a comment

Choose a reason for hiding this comment

adamkankovsky commented Jan 16, 2025

adamkankovsky commented Feb 11, 2025

github-actions bot commented Feb 11, 2025

adamkankovsky commented Feb 11, 2025

KKoukiou commented Feb 12, 2025

KKoukiou commented Feb 12, 2025

KKoukiou commented Feb 12, 2025

github-actions bot commented Feb 12, 2025

KKoukiou commented Feb 12, 2025

KKoukiou commented Feb 12, 2025

adamkankovsky commented Feb 12, 2025

KKoukiou commented Feb 12, 2025

adamkankovsky commented Feb 12, 2025

adamkankovsky commented Feb 12, 2025

adamkankovsky commented Feb 12, 2025

pep8speaks commented Jan 14, 2025 •

edited

Loading

jkonecny12 commented Jan 14, 2025 •

edited

Loading