network: start network-online.target if network is needed #6192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Activation of the micro-dnsconfd and unbound services depend on it (are wanted by the target). This is rather dirty solution forced by the way anaconda currently signals to dracut that it needs network. (Starting the target multiple times as it can happen if several boot options require networing should not matter though). One improvement would be have a script hooked that would check the /tmp/net.ifaces just once at the right time. Proper solution would probably involve anaconda service wanting the target in case the installation requires network. This is logic the service would need to implement (the service start conditions) is now scattered among the parse-anaconda-* hooks creating the /tmp/net.ifaces in the set_neednet function. Migrating to the service This has high potential to break some use cases though, so it should be checked upstream first.
|
/kickstart-test --testtype smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activation of the micro-dnsconfd and unbound services depend on it (are wanted by the target).
This is rather dirty solution forced by the way anaconda currently signals to dracut that it needs network. (Starting the target multiple times as it can happen if several boot options require networing should not matter though).
One improvement would be have a script hooked that would check the /tmp/net.ifaces just once at the right time.
Proper solution would probably involve anaconda service wanting the target in case the installation requires network. This is logic the service would need to implement (the service start conditions) is now scattered among the parse-anaconda-* hooks creating the /tmp/net.ifaces in the set_neednet function. Migrating to the service This has high potential to break some use cases though, so it should be checked upstream first.