Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add edns test #1374

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add edns test #1374

wants to merge 5 commits into from
+305 −0

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Feb 26, 2025 •
edited
Loading

Requires dnsconfd 1.7.2 to pass.

jstodola
jstodola reviewed Feb 26, 2025
View reviewed changes
Copy link
Contributor

@jstodola jstodola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add similar tests to %pre section?

@rvykydal
Copy link
Contributor Author

Could you also add similar tests to %pre section?

Yes, good idea, thank you for great review.

@rvykydal rvykydal force-pushed the add-edns-test branch 3 times, most recently from c739735 to a6dc33f Compare February 27, 2025 13:08
@rvykydal
Copy link
Contributor Author

Could you also add similar tests to %pre section?

Yes, good idea, thank you for great review.

I had to use nslookup here. All the other tests were able to use getent from installed system.
I prefer to use nslookup in installer env and getent on installed system so that we don't have to install nslookup in the test. (This way it could be also more suitable for image payload tests where installing additional packages for test can be problem)

@rvykydal rvykydal marked this pull request as ready for review February 27, 2025 13:54
@rvykydal rvykydal requested a review from jstodola February 28, 2025 08:05
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 3, 2025
View reviewed changes
@rvykydal
Copy link
Contributor Author

rvykydal commented Mar 3, 2025

I've added 2 variants of the tests. Using KICKSTART_NAME mechanism for sharing the .ks file. We should adapt the logic for getting tests impacted by a change to take it into account. Filed #1377

jstodola
jstodola approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@jstodola jstodola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstodola jstodola jstodola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvykydal @jstodola