Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network from kickstart version of e2e edns test #1381

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add network from kickstart version of e2e edns test #1381

wants to merge 2 commits into from

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Mar 4, 2025

In this test only global dns is set via boot options. Everything else comes from kickstart, including default dhcp network.

Related: INSTALLER-4096

@rvykydal rvykydal requested a review from jstodola March 4, 2025 09:06
jstodola
jstodola reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@jstodola jstodola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One encrypted DNS server is set by the rd.net.dns boot option, another DNS (without encryption) is possibly set by the network --bootproto=dhcp kickstart command.
The test checks that hostname resolution works, but it doesn't care what DNS server is really used.
Could you please add a check that the eDNS server is really used for hostname resolution?

@rvykydal
Copy link
Contributor Author

rvykydal commented Mar 4, 2025

Good point, I have to figure out how :)

@rvykydal
Copy link
Contributor Author

rvykydal commented Mar 5, 2025 •
edited
Loading

One encrypted DNS server is set by the rd.net.dns boot option, another DNS (without encryption) is possibly set by the network --bootproto=dhcp kickstart command. The test checks that hostname resolution works, but it doesn't care what
DNS server is really used. Could you please add a check that the eDNS server is really used for hostname resolution?

@jstodola I don't know how to check the use of eDNS server.
I realized that I'll rather add this use case as another test with same setup we have for the 3 already existing (that is, static network configuration without another DNS server) and handle dhcp configured networking separately. Added a commit doing it.
And explore how to check the DNS server that was used.

@rvykydal rvykydal force-pushed the add-edns-test-ksnet branch from 901078f to c99bfcb Compare March 5, 2025 12:24
rvykydal added 2 commits March 5, 2025 13:24
@rvykydal
Add network from kickstart version of e2e edns test
d686132 
In this test only global dns is set via boot options. Everything else
comes from kickstart, including default dhcp network.

Related: INSTALLER-4096
@rvykydal
Use rather static network configuration in ksnet e2e edns test
4a1d37e 
Let's add this use case to those we already have and check dhcp in
another more representative test. We also need to figure out how to
check the DNS server that was actually used.
@rvykydal rvykydal force-pushed the add-edns-test-ksnet branch from c99bfcb to 4a1d37e Compare March 5, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstodola jstodola jstodola left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvykydal @jstodola