Bump observatorium to latest #223
Conversation
| @@ -3,227 +3,628 @@ kind: Template | |||
| metadata: | |||
| name: observatorium | |||
| objects: | |||
| - apiVersion: apps/v1 | |||
There was a problem hiding this comment.
This is scary, do we know what happened here?
There was a problem hiding this comment.
It does not feel like reorder, there are just more lines, plus the change is hardly reviewable 🤔 Wonder if there is a way to improve this so we can have more certainty of this?
There was a problem hiding this comment.
I wanted to ask you the same question as I am just starting with jsonent.
The intent here is to bump obs/obs jsonnet (namely the tracing one). If there is a way to just bump a single jsonnet I would prefer that, but I didn't find the solution for that.
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>
Root cause: https://github.com/observatorium/observatorium/pull/479/files#diff-ffa89b403cdc750f5a7ce9bd62384d4cae7fd821b8b88dafab9aba055f7ee5fd Signed-off-by: Bartlomiej Plotka <[email protected]>
|
Majority problems comes from this change: Ref: observatorium/observatorium#479 I fixed the problem - we changed the key so prefix filtering had to be adjusted. cc @douglascamata @pavolloffay I confirmed (after debugging sort of elements) that now the file is exactly the same:
|
|
I cannot provide sort function given linter bug: #227 |
| !std.startsWith(name, 'thanos-') && | ||
| !std.startsWith(name, 'loki-') && | ||
| !std.startsWith(name, 'tracing-') | ||
| !std.startsWith(name, 'observatorium/thanos-') && | ||
| !std.startsWith(name, 'observatorium/loki-') && | ||
| !std.startsWith(name, 'observatorium/tracing-') |
There was a problem hiding this comment.
@bwplotka you have eagle eyes. Great catch! 🏅
|
Amazing. Thanks a lot for the investigation and solution, @bwplotka. I didn't imagine the original PR to Observatorium could have such side effects 😬 |
Signed-off-by: Pavol Loffay [email protected]