Add integration–test code base to rhobs/config #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vprashar2929
force-pushed
the
add-integration-test
branch
5 times, most recently
from
d80aa4b
to
60e9a92
Compare
vprashar2929
changed the title
Signed-off-by: Vibhu Prashar <[email protected]>
vprashar2929
force-pushed
the
add-integration-test
branch
from
60e9a92
to
f041867
Compare
philipgough
approved these changes
Aug 1, 2023
saswatamcode
reviewed
Aug 2, 2023
go.mod
Outdated
| @@ -7,7 +7,9 @@ require ( | |||
| github.com/observatorium/api v0.1.3-0.20220621123450-69c5f2661d01 | |||
| github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.60.1 | |||
| github.com/pyrra-dev/pyrra v0.5.2 | |||
| k8s.io/apimachinery v0.25.3 | |||
| k8s.io/api v0.27.4 | |||
There was a problem hiding this comment.
Given that we will move to Go based config soon...let's actually move this to a separate module? Like a new go.mod in framework dir
There was a problem hiding this comment.
Absolutely we can. I also want to keep the integration-test's related stuff isolated from the configuration.
Signed-off-by: Vibhu Prashar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the integration-test's code base to rhobs/config. It doesn't delete the existing post-deploy job code but adds a new folder
frameworkinsidetests/inetgration_tests